Closed Bug 598147 Opened 14 years ago Closed 14 years ago

Can't call method "isa" without a package or object reference at ./email_in.pl line 377.

Categories

(Bugzilla :: Incoming Email, defect)

Product:
Bugzilla
Component:
Incoming Email
Version:
3.6.2
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.6

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

Attachments

(1 file, 1 obsolete file)

patch, v2
1.05 KB, patch
mkanat
: review+
Details | Diff | Splinter Review
Attached patch patch, v1 (obsolete) — — Splinter Review 
If $msg is not an object, 'Can't call method "isa" without a package or object reference' is thrown instead of the expected error message. This happens if you call ThrowUserError() with an error tag defined in your extension (this doesn't happen when the error tag is in user-error.html.tmpl itself).
Attachment #476913 - Flags: review?(mkanat)
Comment on attachment 476913 [details] [diff] [review]
patch, v1

Mmm, should use "blessed" instead of "ref", because $@ could be an unblessed reference, which would also fail.
Attachment #476913 - Flags: review?(mkanat) → review-
Target Milestone: --- → Bugzilla 3.6
Attached patch patch, v2 — — Splinter Review 
Assignee: incoming.email → LpSolit

        Attachment #476913 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #477301 -
        Flags: review?(mkanat)

    
    

    
  
Comment on attachment 477301 [details] [diff] [review]
patch, v2

I think that makes the line longer than 80 characters, though, so just add a newline on checkin.

        Attachment #477301 -
        Flags: review?(mkanat) → review+

    
  
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+

    
    

    
  
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified email_in.pl
Committed revision 7486.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified email_in.pl
Committed revision 7415.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified email_in.pl
Committed revision 7180.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: